Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to Gradle for language and diagram server build #1469

Merged
merged 9 commits into from
Nov 15, 2022

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Nov 11, 2022

Replaces the Maven build configuration (+ Pythons script) with a Gradle task for building the LDS jar.
See PR 85 in VSC-LF for associated adjustments.

@a-sr a-sr added build system gradle Issues regarding Gradle build configuration labels Nov 11, 2022
@a-sr a-sr marked this pull request as ready for review November 11, 2022 15:32
@a-sr a-sr requested a review from lhstrh November 11, 2022 15:33
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Unfortunately our CI seems to be broken at the moment. We have multiple open PRs where the workflows did not trigger.

@cmnrd
Copy link
Collaborator

cmnrd commented Nov 11, 2022

The CI configuration was broken on master... I fixed it now.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Real progress 🚀

org.lflang.ide/build.gradle Outdated Show resolved Hide resolved
Added missing newline

Co-authored-by: Marten Lohstroh <[email protected]>
@lhstrh lhstrh merged commit 081250d into master Nov 15, 2022
@lhstrh lhstrh deleted the lds-gradle-build branch November 15, 2022 19:24
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system enhancement Enhancement of existing feature gradle Issues regarding Gradle build configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants